Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL's for inline images not updated on destination #1262

Open
1 task done
willemb2 opened this issue Aug 15, 2024 · 4 comments
Open
1 task done

URL's for inline images not updated on destination #1262

willemb2 opened this issue Aug 15, 2024 · 4 comments
Labels
help wanted type:bug Something isn't working.
Milestone

Comments

@willemb2
Copy link

willemb2 commented Aug 15, 2024

Describe your question

This plugin works very reliable for us for the text, styling and featured image of posts. Attached inline images (WordPress calls it 'Uploaded to' nowadays) get pushed/pulled to the destination media library as well, but the URL's for the inline images keep pointing to the source site.

We're using 2.0.4. On both ends we have chosen the setting Process the featured image and any attached images. We're using the Classic Editor.

I think our issue is similar to #975 . That has been closed a long time ago. I'm not really familiar with the Github workflow and terminology. Does it mean this should have been fixed?

Below is a copy of our Site Health - Info where I replaced the domain by example.com:

Site Health - Info

### wp-core ###

version: 6.6.1
site_language: nl_NL
user_language: en_US
timezone: Europe/Amsterdam
permalink: /%postname%/
https_status: true
multisite: false
user_registration: 0
blog_public: 1
default_comment_status: closed
environment_type: production
user_count: 7
dotorg_communication: true

wp-paths-sizes

wordpress_path: /var/www/vhosts/example.com/httpdocs
wordpress_size: loading...
uploads_path: /var/www/vhosts/example.com/httpdocs/wp-content/uploads
uploads_size: loading...
themes_path: /var/www/vhosts/example.com/httpdocs/wp-content/themes
themes_size: loading...
plugins_path: /var/www/vhosts/example.com/httpdocs/wp-content/plugins
plugins_size: loading...
fonts_path: /var/www/vhosts/example.com/httpdocs/wp-content/uploads/fonts
fonts_size: loading...
database_size: loading...
total_size: loading...

wp-dropins (1)

maintenance.php: true

wp-active-theme

name: ColorMag Pro Child Theme (colormag-pro-child)
version: 1.0
author: ThemeGrill
author_website: http://themegrill.com
parent_theme: ColorMag Pro (colormag-pro)
theme_features: core-block-patterns, widgets-block-editor, block-templates, automatic-feed-links, post-thumbnails, menus, custom-background, title-tag, post-formats, html5, custom-logo, auto-load-next-post, customize-selective-refresh-widgets, align-wide, wp-block-styles, responsive-embeds, custom-header, widgets
theme_path: /var/www/vhosts/example.com/httpdocs/wp-content/themes/colormag-pro-child
auto_update: Disabled

wp-parent-theme

name: ColorMag Pro (colormag-pro)
version: 4.1.6.1 (latest version: 4.1.10)
author: ThemeGrill
author_website: https://themegrill.com/wordpress-themes/
theme_path: /var/www/vhosts/example.com/httpdocs/wp-content/themes/colormag-pro
auto_update: Disabled

wp-themes-inactive (2)

ColorMag: version: 3.1.7.1, author: ThemeGrill (latest version: 3.1.10), Auto-updates disabled
Twenty Twenty-Four: version: 1.1, author: the WordPress team (latest version: 1.2), Auto-updates disabled

wp-plugins-active (22)

AdRotate Professional: version: 5.16.3, author: Arnan de Gans, Auto-updates disabled
Advanced Editor Tools: version: 5.9.2, author: Automattic, Auto-updates enabled
AH Display Widgets: version: 1.0.3, author: Andreas Hecht, Auto-updates enabled
Bulk remove posts from category: version: 3.3, author: MasterNs, Auto-updates enabled
Classic Editor: version: 1.6.4, author: WordPress Contributors, Auto-updates enabled
Classic Widgets: version: 0.3, author: WordPress Contributors, Auto-updates enabled
Distributor: version: 2.0.4, author: 10up Inc., Auto-updates enabled
Easy Accordion Gutenberg Block: version: 1.2.2, author: Zakaria Binsaifullah, Auto-updates enabled
Exclude Category from Blog: version: 1.2, author: Magic Hills Pty Ltd, Auto-updates enabled
Independent Analytics: version: 2.7.3, author: Independent Analytics, Auto-updates enabled
Members: version: 3.2.9, author: MemberPress, Auto-updates enabled
Newsletter: version: 8.4.7, author: Stefano Lissa & The Newsletter Team, Auto-updates enabled
Newsletter - Addons Manager and Support: version: 1.3.1, author: The Newsletter Team, Auto-updates enabled
Newsletter - Bounce Addon: version: 1.3.1, author: The Newsletter Team, Auto-updates enabled
Newsletter - Extended Composer Blocks: version: 1.5.5, author: The Newsletter Team, Auto-updates enabled
Newsletter - Import/Export: version: 1.5.2, author: The Newsletter Team, Auto-updates enabled
Newsletter - Reports and Retargeting: version: 4.5.9, author: The Newsletter Team, Auto-updates enabled
Ninja Forms: version: 3.8.10, author: Saturday Drive (latest version: 3.8.12), Auto-updates disabled
Post Types Order: version: 2.2.6, author: Nsp Code, Auto-updates enabled
Really Simple SSL: version: 8.1.6, author: Really Simple Plugins, Auto-updates enabled
Simple Lightbox: version: 2.9.3, author: Archetyped, Auto-updates disabled
WP Mail SMTP: version: 4.1.0, author: WP Mail SMTP (latest version: 4.1.1), Auto-updates enabled

wp-plugins-inactive (3)

Customizer Export/Import: version: 0.9.7, author: The Beaver Builder Team, Auto-updates enabled
Regenerate Thumbnails: version: 3.1.6, author: Alex Mills (Viper007Bond), Auto-updates disabled
TinyMCE Custom Styles: version: 1.1.5, author: Tim Reeves, Auto-updates enabled

wp-media

image_editor: WP_Image_Editor_GD
imagick_module_version: Not available
imagemagick_version: Not available
imagick_version: Not available
file_uploads: 1
post_max_size: 768M
upload_max_filesize: 768M
max_effective_size: 768 MB
max_file_uploads: 20
gd_version: 2.3.3
gd_formats: GIF, JPEG, PNG, WebP, BMP, AVIF, XPM
ghostscript_version: unknown

wp-server

server_architecture: Linux 3.10.0-962.3.2.lve1.5.81.el7.x86_64 x86_64
httpd_software: Apache
php_version: 8.1.22 64bit
php_sapi: fpm-fcgi
max_input_variables: 1000
time_limit: 650
memory_limit: 512M
max_input_time: 600
upload_max_filesize: 768M
php_post_max_size: 768M
curl_version: 7.87.0 OpenSSL/1.1.1p
suhosin: false
imagick_availability: false
pretty_permalinks: true
htaccess_extra_rules: true
current: 2024-08-15T15:21:27+00:00
utc-time: Thursday, 15-Aug-24 15:21:27 UTC
server-time: 2024-08-15T17:21:25+02:00

wp-database

extension: mysqli
server_version: 10.6.14-MariaDB-cll-lve
client_version: 10.6.14-MariaDB
max_allowed_packet: 16777216
max_connections: 151

wp-constants

WP_HOME: undefined
WP_SITEURL: undefined
WP_CONTENT_DIR: /var/www/vhosts/example.com/httpdocs/wp-content
WP_PLUGIN_DIR: /var/www/vhosts/example.com/httpdocs/wp-content/plugins
WP_MEMORY_LIMIT: 40M
WP_MAX_MEMORY_LIMIT: 512M
WP_DEBUG: false
WP_DEBUG_DISPLAY: true
WP_DEBUG_LOG: false
SCRIPT_DEBUG: false
WP_CACHE: false
CONCATENATE_SCRIPTS: undefined
COMPRESS_SCRIPTS: undefined
COMPRESS_CSS: undefined
WP_ENVIRONMENT_TYPE: Undefined
WP_DEVELOPMENT_MODE: undefined
DB_CHARSET: utf8
DB_COLLATE: undefined

wp-filesystem

wordpress: writable
wp-content: writable
uploads: writable
plugins: writable
themes: writable
fonts: not writable

wp_mail_smtp

version: 4.1.0
license_key_type: lite
debug: No debug notices found.
lite_install_date: Dec 2, 2023 @ 12:00pm

distributor

0: 2.0.4
1: Yes
2: [email protected]
3:
Override Author Byline: Yes
Media Handling: Featured image and attached images
4: N/A
5:
Example2:

  • URL: https://example2.com/wp-json/
  • Version: 2.0.4
  • Status: valid
  • Auth method: Username / Password
  • Username: somenerd
  • Roles Allowed to Push: administrator, editor, zeepost-auteur
  • Additional data: {"errors":[], "can_post":["post", "page", "attachment", "nav_menu_item", "wp_block", "wp_template", "wp_template_part", "wp_navigation", "wp_font_family", "wp_font_face", "tribe_venue", "tribe_organizer", "tribe_events"], "can_get":["post", "page", "attachment", "nav_menu_item", "wp_block", "wp_template", "wp_template_part", "wp_navigation", "wp_font_family", "wp_font_face", "tribe_venue", "tribe_organizer", "tribe_events"], "endpoint_suggestion":false, "is_authenticated":"yes"}
    Example3:
  • URL: https://www.example3.com/wp-json/
  • Version: 2.0.4
  • Status: valid
  • Auth method: Username / Password
  • Username: somenerd
  • Roles Allowed to Push: administrator, editor, zeepost-auteur
  • Additional data: {"errors":[], "can_post":["post", "page", "attachment", "nav_menu_item", "wp_block", "wp_template", "wp_template_part", "wp_navigation", "wp_font_family", "wp_font_face", "tribe_venue", "tribe_organizer", "tribe_events"], "can_get":["post", "page", "attachment", "nav_menu_item", "wp_block", "wp_template", "wp_template_part", "wp_navigation", "wp_font_family", "wp_font_face", "tribe_venue", "tribe_organizer", "tribe_events"], "endpoint_suggestion":false, "is_authenticated":"yes"}

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jeffpaul
Copy link
Member

jeffpaul commented Oct 1, 2024

Perhaps related to #1278.

@jeffpaul jeffpaul added type:bug Something isn't working. help wanted and removed type:question Further information is requested. labels Oct 1, 2024
@willemb2
Copy link
Author

willemb2 commented Oct 1, 2024

Perhaps related to #1278.

The issue in #1278 is described as

"The images from the media library are not being saved in the destination’s media library"

Our case is different: the images ARE saved in the destination’s media library. It's just that the URL for inline images are not updated in the post on the destination. Only for the featured image it is.

@dkotter
Copy link
Collaborator

dkotter commented Oct 1, 2024

@willemb2 Note this is a known limitation in Distributor, where we send images over (if the setting is on) but we don't update the actual URLs in the content. Can see #975 (comment) for more details around that. This is something we'd like to add but gets a little tricky dealing with different image sizes each site may or may not support, so it's not as simple as a find/replace for those URLs.

@willemb2
Copy link
Author

willemb2 commented Oct 1, 2024

@dkotter

known limitation

But not a documented limitation. For us it was the main reason to try Distributor. What is the point in copying over the images to the destination if you can't update the URLs?
In our situation we have the same theme and settings on source and destination. In our tests I'm seeing the images appear in the media library on the destination. I also checked the /wp-conten/uploads/ directory and verified that other sizes are being generated just like on the source.
I updated the URLs with find&replace in the post source and I'm seeing no issues whatsoever. But updating the URLs manually is asking too much from my content editors. We cannot use Distributor in production this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type:bug Something isn't working.
Projects
Status: To Do
Development

No branches or pull requests

3 participants