Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign inner transactions, contract delegations, raw data #13

Open
davidyuk opened this issue Oct 3, 2024 · 0 comments
Open

Sign inner transactions, contract delegations, raw data #13

davidyuk opened this issue Oct 3, 2024 · 0 comments

Comments

@davidyuk
Copy link

davidyuk commented Oct 3, 2024

Inner transactions

It is a transaction that can be used as a payload for pay-for-tx. Snap should accept a flag to add "inner_tx" after the network id while signing the transaction.

https://github.com/aeternity/aepp-sdk-js/blob/6c2dbfe0f2bcf708985da4eee6e3045aefd6310f/src/account/Memory.ts#L14-L17

Also, this should be indicated to the user.

Contract delegations

A delegation is expected to be provided as a buffer. Use unpackDelegation to show its details to the user. If confirmed, sign delegation this way.

Raw data, unsafe signing

There are edge cases, like signing a JWT where this ability is necessary. Example interface: https://github.com/aeternity/aepp-sdk-js/blob/6c2dbfe0f2bcf708985da4eee6e3045aefd6310f/src/aepp-wallet-communication/rpc/types.ts#L53-L56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant