Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix physconst units #283

Open
peverwhee opened this issue Aug 1, 2024 · 0 comments
Open

Fix physconst units #283

peverwhee opened this issue Aug 1, 2024 · 0 comments
Labels
bug Something isn't working correctly misc Issue that can be included in a miscellaneous PR

Comments

@peverwhee
Copy link
Collaborator

What happened?

A couple of physconst units are wrong in src/data/physconst.meta:

  • avogadro_number should be molecules kmol-1
  • boltzmann_constant should be J K-1 molecule-1

What are the steps to reproduce the bug?

Not reproducible. No schemes are currently using either erroneously unit-ed variable.

What CAM-SIMA hash were you using?

8ac3838

What machine were you running CAM-SIMA on?

CISL machine (e.g. cheyenne)

What compiler were you using?

Intel

Path to a case directory, if applicable

No response

Will you be addressing this bug yourself?

Any Software Engineer can do this

Extra info

Just need to update the units in .meta; the comments in .F90 are correct.
@peverwhee peverwhee added the bug Something isn't working correctly label Aug 1, 2024
@peverwhee peverwhee mentioned this issue Aug 1, 2024
Closed
@peverwhee peverwhee added the misc Issue that can be included in a miscellaneous PR label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly misc Issue that can be included in a miscellaneous PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peverwhee