Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New parameterization of vegetation surface roughness for forests #1316

Closed
RonnyMeier opened this issue Mar 30, 2021 · 3 comments · Fixed by #2045
Closed

New parameterization of vegetation surface roughness for forests #1316

RonnyMeier opened this issue Mar 30, 2021 · 3 comments · Fixed by #2045
Labels
enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science

Comments

@RonnyMeier
Copy link
Contributor

The vegetation surface roughness (z0) of deciduous trees is close to the z0 of the ground when the trees shed their leaves. This is in contradiction to observations, which even observe an increase of z0 during the dormant phase. Therefore, we intend to introduce a new parameterization of the vegetation z0 for the forest PFTs, probably using the proposed parameterization of Nakai et al. (2008) (https://doi.org/10.1016/j.agrformet.2008.03.009). Steps to be taken:

  1. Implement parameterization of Nakai et al. (already done). Could test other parameterizations later on too.
  2. Use data of Hu et al. (2020) (https://doi.org/10.1016/j.agrformet.2020.107956) to tune parameters in parameterization.
  3. Assess how new parameterization affects model performance.
  4. Potentially do additional tuning.
@billsacks billsacks added tag: enh - new science enhancement new capability or improved behavior of existing capability next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Mar 30, 2021
@wwieder
Copy link
Contributor

wwieder commented Apr 1, 2021

@RonnyMeier this looks like exciting work (sorry I missed your presentation last week).
We'd welcome these changes as on option that users can chose in CTSM simulations and we'd like to help you bring this into the CTSM code base. To do this it seems to me like you kind of have two options here:

  1. Submit a pull request (PR) with your progress on implementing the Nakai parameterization

OR

  1. You can wait until you have the Hu data to parameterize and evaluate your code modifications before opening up the PR.

Either option is fine. Once you start the PR you can start working with the software engineering team to put namelist switches around your code so we can turn on/off your new roughness parameterization. The ctsm wiki has helpful suggestions for getting ready for and submitting your PR.

Please reach out if you have questions or concerns along the way.

@wwieder wwieder removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Apr 1, 2021
@wwieder
Copy link
Contributor

wwieder commented Apr 1, 2021

To follow up, @RonnyMeier, you'll notice that @rgknox linked this issue to one in FATES. The FATES team is also interested in this work and (I think) would welcome contributions to the FATES code base too. Unfortunately, this is somewhat duplicative at this stage. BUT once you have the code up, running, and incorporated into the big-leaf OR FATES code it will hopefully be pretty straightforward to migrate it over to the other. There may need to be additional testing and evaluation of the parameterizations used in each model, however.

@RonnyMeier
Copy link
Contributor Author

@wwieder: Thank you for your support. In the meantime, we got access to the data of Hu et al. I am working right now on adapting the proposed parameterization of Nakai et al. to the site data. So far, I can confirm that the z0 of forests in the current implementation is underestimated drastically, while the z0 for grasses and crops seems reasonable. I will contact you in case I have questions regarding the incroporation of the new parameterization in the code and make a PR once we are ready.

@rgknox: We could definitely consider introducing a similar parameterization to FATES. I assume FATES simulates the tree number density, which would be advantageous for the parameterization of Nakai. I propose that we finalize our development for the big-leaf version first. Once this is done, we can get in contact with you and discuss how our development could be added to FATES.

@edavin: Welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science
Projects
None yet
4 participants