Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing subspace provider in FDBRecordStore logs #2936

Open
alecgrieser opened this issue Oct 4, 2024 · 0 comments · May be fixed by #2937
Open

Missing subspace provider in FDBRecordStore logs #2936

alecgrieser opened this issue Oct 4, 2024 · 0 comments · May be fixed by #2937
Assignees
Labels
bug Something isn't working

Comments

@alecgrieser
Copy link
Contributor

There are a couple of places in FDBRecordStore where we're logging information about something that happened in the store, but we're not including the subspace provider so we're missing out on which record store the log is about. For example, the "index state change" message, indicating an index was either enabled or disabled, is missing those log keys.

@alecgrieser alecgrieser added the bug Something isn't working label Oct 4, 2024
@alecgrieser alecgrieser self-assigned this Oct 4, 2024
alecgrieser added a commit to alecgrieser/fdb-record-layer that referenced this issue Oct 4, 2024
…logs

There were a handful of places in the `FDBRecordStore` class that were were logging but didn't include the subspace provider as context. This means that we couldn't tell what store the logs were trying to log about, which made it hard to correlate with other operations to the store. This resolves that by adding in the missing information to the missing logs.

This fixes FoundationDB#2936.
alecgrieser added a commit to alecgrieser/fdb-record-layer that referenced this issue Oct 4, 2024
…logs

There were a handful of places in the `FDBRecordStore` class that were were logging but didn't include the subspace provider as context. This means that we couldn't tell what store the logs were trying to log about, which made it hard to correlate with other operations to the store. This resolves that by adding in the missing information to the missing logs.

This fixes FoundationDB#2936.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant