Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2936: Missing subspace provider in FDBRecordStore logs #2937

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes #2936: Missing subspace provider in FDBRecordStore logs #2937

wants to merge 1 commit into from
+13 −6

Conversation

alecgrieser
Copy link
Contributor

There were a handful of places in the FDBRecordStore class that were were logging but didn't include the subspace provider as context. This means that we couldn't tell what store the logs were trying to log about, which made it hard to correlate with other operations to the store. This resolves that by adding in the missing information to the missing logs.

This fixes #2936.

@alecgrieser
Fixes FoundationDB#2936: Missing subspace provider in FDBRecordStore …
f64a4ba 
…logs

There were a handful of places in the `FDBRecordStore` class that were were logging but didn't include the subspace provider as context. This means that we couldn't tell what store the logs were trying to log about, which made it hard to correlate with other operations to the store. This resolves that by adding in the missing information to the missing logs.

This fixes FoundationDB#2936.
@foundationdb-ci
Copy link
Contributor

Result of fdb-record-layer-pr on Linux CentOS 7

  • Commit ID: f64a4ba
  • Duration 0:17:41
  • Result: ❌ FAILED
  • Error: Error while executing command: ./gradlew --no-daemon --console=plain -b ./build.gradle build destructiveTest -PcoreNotStrict -PreleaseBuild=false -PpublishBuild=false -PspotbugsEnableHtmlReport. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing subspace provider in FDBRecordStore logs
2 participants
@alecgrieser @foundationdb-ci