Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default gaz separator from : to tab #15

Open
greenwoodma opened this issue Feb 17, 2021 · 2 comments
Open

change default gaz separator from : to tab #15

greenwoodma opened this issue Feb 17, 2021 · 2 comments

Comments

@greenwoodma
Copy link
Contributor

it would be great if we could change the default gaz separator from : to tab. The question is what would this break? It shouldn't break any apps that just use ANNIE with the default settings as these don't get saved into the xgapp any more, but it would break any apps that have taken a copy of the ANNIE gaz files and edited them. Is it worth breaking these to give us a more sensible default separator?

@ianroberts
Copy link
Member

Since we don't save parameter values that match the default, changing this now will break any app saved in 8.5 or later with a gazetteer that either (a) deliberately uses : as its feature separator or (b) contains tab characters in any of its list entries.

@greenwoodma
Copy link
Contributor Author

Yes. I'm wondering if there is a clean solution involving hiding the existing gaz PR and having a subclass with more sensible defaults, but I'm struggling to come up with a working solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants