Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentioning how "Manual Mode" works #18

Open
davideravasi opened this issue Jul 8, 2022 · 1 comment
Open

Mentioning how "Manual Mode" works #18

davideravasi opened this issue Jul 8, 2022 · 1 comment

Comments

@davideravasi
Copy link

davideravasi commented Jul 8, 2022

Hello!
Me and my teams were debugging an issue and we ended up in reviewing this page: https://github.com/IdentityModel/Documentation/blob/main/docs/native/manual.rst

Is not mentioned what happens under the hood and, if you are not a very skilled developer already familiar with Oauth2/OIDC you can misunderstand and think that the comment > "// generate start URL, state, nonce, code challenge" means a generation done offline and done in your device (or any other fancy client).

Then, if you call the method "await client.PrepareLoginAsync();" without a proper internet connection in a try catch you see the error in the screenshot that basically explain what happens under the hood.
Screenshot 2022-07-08 at 11 20 00

Can we mention in the comment above the method that the discovery endpoint is called under the hood? It's very important because as I said, especially if you are not familiar you can misunderstand that these parameters are generated locally or on the backend side you don't know what is called and why maybe is not working.

Thank you in advance!

@leastprivilege
Copy link
Contributor

This is a FOSS project - so please feel free to propose a PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants