Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online tests CloudFormation self-destruct trigger flawed #7

Open
omus opened this issue Mar 3, 2021 · 2 comments
Open

Online tests CloudFormation self-destruct trigger flawed #7

omus opened this issue Mar 3, 2021 · 2 comments

Comments

@omus
Copy link
Member

omus commented Mar 3, 2021

The online tests use a CFN stack that is supposed to stay up for ~3 hours after any activity. Currently the detection of activity is flawed as it requires that a change occurs to the stack and not just an attempt to update the stack. This is problematic as it could result in the stack self-destructing while it's being used.

Specifically, an CFN update that results in no change does not reset the timer.

@omus
Copy link
Member Author

omus commented Mar 4, 2021

I was thinking about this a little bit and I came up with a couple of options to try:

  • Use CFN tags/parameters to always make a change to the stack to ensure the last updated entry gets updated
  • Modify the deletion check lambda to check for activity using other services such as the last AWS Batch job executed

@iamed2
Copy link
Member

iamed2 commented Mar 8, 2021

If we use aws cloudformation deploy --no-fail-on-empty-changeset we might be able to get an update event even when no change occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants