Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old code #41

Open
2 of 5 tasks
dpsanders opened this issue Mar 12, 2018 · 3 comments · May be fixed by #203
Open
2 of 5 tasks

Remove old code #41

dpsanders opened this issue Mar 12, 2018 · 3 comments · May be fixed by #203

Comments

@dpsanders
Copy link
Member

dpsanders commented Mar 12, 2018

Remove old code:

  • bisection.jl

  • move out definitions of N used in branch_and_prune

  • krawczyk.jl

  • newton.jl

  • find_roots stuff

@Kolaru
Copy link
Collaborator

Kolaru commented Mar 4, 2019

Is the code in newton1d.jl still considered maintained and part of the current API ?

@dpsanders
Copy link
Member Author

That was added in last year's GSoC project.

In a way it's useful to have a separate code, but the actual code itself is long and convoluted. We should see if anything is salvagable and probably get rid of the rest.

cc @eeshan9815

@eeshan9815
Copy link
Contributor

If I recall correctly, it worked well for complicated functions, and functions which had a lot of multiple roots, where the existing solver sometimes struggled. So, should it be implemented as a part of the roots interface and kept as a different keyword solver?

@OlivierHnt OlivierHnt linked a pull request May 31, 2024 that will close this issue
@OlivierHnt OlivierHnt linked a pull request Jun 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants