Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix /style functionality #1386

Merged
merged 10 commits into from
Jul 23, 2024
Merged

Fix /style functionality #1386

merged 10 commits into from
Jul 23, 2024

Conversation

white238
Copy link
Member

@white238 white238 commented Jul 17, 2024 •
edited
Loading

Couldn't test this until it was in the default branch. This does the following:

  • Removes component based code checks
  • Simplifies axom_add_code_checks macro
  • Run style on more files that are included due to previous bullet point

@white238
Copy link
Member Author

/style

@white238
Copy link
Member Author

... helps if i update my develop before trying this out...

@white238
Copy link
Member Author

/style

@white238
Copy link
Member Author

/style

@white238
Copy link
Member Author

Sigh, our style targets is based on which components we have enabled. I'll fix that.....

@white238
Copy link
Member Author

/style

@rhornung67
Copy link
Member

@white238 this PR proves you've got STYLE!

@white238 white238 changed the title DO NOT MERGE: Test style by comment Fix /style functionality Jul 17, 2024
@white238 white238 added bug Something isn't working CI Issues related to continuous integration Build system Issues related to Axom's build system labels Jul 17, 2024
rhornung67
rhornung67 reviewed Jul 17, 2024
View reviewed changes
Copy link
Member

@rhornung67 rhornung67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could omit this file from the style check.....

@white238
Copy link
Member Author

Yea... maybe not style the configured files since it doesn't seem to deal well with the CMake syntax?

@white238 white238 merged commit 0cf501c into develop Jul 23, 2024
13 checks passed
@white238 white238 deleted the white238/test_auto_style branch July 23, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhornung67 rhornung67 rhornung67 approved these changes

@bmhan12 bmhan12 bmhan12 approved these changes

@kennyweiss kennyweiss Awaiting requested review from kennyweiss

@gunney1 gunney1 Awaiting requested review from gunney1

@BradWhitlock BradWhitlock Awaiting requested review from BradWhitlock

@agcapps agcapps Awaiting requested review from agcapps

Assignees
No one assigned
Labels
bug Something isn't working Build system Issues related to Axom's build system CI Issues related to continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@white238 @rhornung67 @bmhan12