removeFile() Usage #1424
removeFile() Usage #1424
Conversation
bmhan12
added
Core
src/axom/slic/tests/slic_macros.cpp
Outdated
| // Closes open file streams associated with Slic streams when destructors | ||
| // called during slic::finalize(). | ||
| // Windows _unlink file deletion fails if file is still in use. | ||
| #ifdef WIN32 |
There was a problem hiding this comment.
Unless there's a reason non-Windows should not finalize(), let's please remove the guard on WIN32 here and in the slic_macros_parallel.cpp test. If there is a reason to test removeFile() on non-finaliz()ed slic on non-Windows platforms, I would appreciate knowing.
There was a problem hiding this comment.
Guard removed! finalize() call will work on Windows and non-Windows systems, guard was a relic of my testing.
|
@bmhan12 , thank you for your attention to detail on this. |
bmhan12
force-pushed
the
bugfix/han12/removeFile_Windows
branch
from
fdc0fed
to
e528819
Compare
| @@ -457,7 +456,7 @@ TEST(slic_macros, test_macros_file_output) | |||
| std::string no_fmt_expected; | |||
| no_fmt_expected += "*****\n[INFO]\n\n Test \n\n "; | |||
| no_fmt_expected += __FILE__; | |||
| no_fmt_expected += "\n441\n****\n"; | |||
| no_fmt_expected += "\n440\n****\n"; | |||
There was a problem hiding this comment.
What is 440 here? Is it a line number?
It might make sense to add a comment about this for future maintenance of these tests.
There was a problem hiding this comment.
What is 440 here? Is it a line number?
Yes. In a follow-up PR related to #1410, I'll be updating these line numbers to be like slic_macros_parallel to be __LINE__ - offset to make that clear.
|
@bmhan12 -- could you please update the documentation for See: axom/src/axom/core/utilities/FileUtilities.hpp Lines 86 to 92 in 24751dd |
This PR:
removeFilefailure on Windows inslic_macros.cppunit test by closing the files associated withifstreamand theofstreammember variables ofLogStreaminstances.removeFilein unit tests to verify file has been deletedCloses issue #1415