Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tooltip component for re-designed confirmation pages #11572

Merged
merged 30 commits into from
Oct 7, 2024
Merged

feat: add tooltip component for re-designed confirmation pages #11572

merged 30 commits into from
Oct 7, 2024
+138 −0

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Oct 2, 2024

Description

add tooltip component for re-designed confirmation pages

Related issues

Fixes: #11565

Manual testing steps

  1. Run storybook locally
  2. Check confirmations -> tooltip

Screenshots/Recordings

Screen.Recording.2024-10-02.at.7.28.27.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Oct 2, 2024
@jpuri jpuri requested review from a team as code owners October 2, 2024 14:04
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

matthewwalsh0
matthewwalsh0 previously approved these changes Oct 3, 2024
View reviewed changes
@jpuri jpuri requested a review from a team as a code owner October 4, 2024 10:44
Base automatically changed from url_value to main October 4, 2024 15:32
@jpuri jpuri dismissed stale reviews from matthewwalsh0 and pedronfigueiredo October 4, 2024 15:32

The base branch was changed.

@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bb0802d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8d9f8a6d-0865-414f-a33b-f9a48fc40c72

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jpuri jpuri added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 7f5e3be Oct 7, 2024
39 of 40 checks passed
@jpuri jpuri deleted the tooltip_component branch October 7, 2024 11:26
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@matthewwalsh0 matthewwalsh0 Awaiting requested review from matthewwalsh0

Assignees
No one assigned
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create tooltip component for mobile
3 participants
@jpuri @pedronfigueiredo @matthewwalsh0