Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify history state instead of overwriting it #6

Open
ema-fox opened this issue Apr 4, 2022 · 0 comments
Open

Modify history state instead of overwriting it #6

ema-fox opened this issue Apr 4, 2022 · 0 comments

Comments

@ema-fox
Copy link

ema-fox commented Apr 4, 2022

Please consider only modifying the history state and not completely overwriting it.

I haven't tested it but[1] changing this line:

state {:scroll-top scroll-top}]

to:
state (assoc (js->clj (get-history-state)) :scroll-top scroll-top)]
should make Clerk play nice with other code that also makes use of the history state.

[1] I have tested it now and it seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant