Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-forceupdate don't work. #2934

Open
C0sm0s-Chill opened this issue Apr 3, 2023 · 6 comments · May be fixed by #3016
Open

-forceupdate don't work. #2934

C0sm0s-Chill opened this issue Apr 3, 2023 · 6 comments · May be fixed by #3016
Labels
Confirmed This is a confirmed issue Contribution Wanted

Comments

@C0sm0s-Chill
Copy link

Hey ! -forceupdate don't work anymore.

@C0sm0s-Chill
Copy link
Author

I close, because obviously the problem will never be solved. If it's to release broken versions, we might as well do nothing.

@Arthri
Copy link
Contributor

Arthri commented Apr 9, 2023

Hello! I understand your frustrations with the slow pace of development. Unfortunately, TShock is an open-source project composed of volunteer work, and no one's free to do address this specific issue at the moment. The issue has already been confirmed(on Discord), if you would like to submit a PR, feel free to

@QuiCM QuiCM added Contribution Wanted Confirmed This is a confirmed issue labels Apr 9, 2023
@PotatoCider
Copy link
Contributor

Related to issue #2205

@C0sm0s-Chill
Copy link
Author

Hello! I understand your frustrations with the slow pace of development. Unfortunately, TShock is an open-source project composed of volunteer work, and no one's free to do address this specific issue at the moment. The issue has already been confirmed(on Discord), if you would like to submit a PR, feel free to

Hello! First of all, thank you for your answer...I must confess that I am quite frustrated about this error. I'm not a coder but I had to create an alternative...I just find it a shame that such an important feature is broken. Sorry if my answer offended some people, it was not my intention, have a nice day everyone.

@sgkoishi
Copy link
Contributor

As said on Discord, even if the update do run, there are still many things that won't update - for example, trees don't grow during the update, but only when player nearby.


You can fix it via several lines of code:

On.Terraria.Netplay.UpdateConnectedClients += (On.Terraria.Netplay.orig_UpdateConnectedClients orig) =>
{
    orig();
    if (ServerApi.ForceUpdate)
    {
        Terraria.Netplay.HasClients = true;
    }
};

@hakusaro
Copy link
Member

hakusaro commented Apr 10, 2023 via email

Metratrj added a commit to Metratrj/TShock that referenced this issue Feb 1, 2024
Add hook for UpdateConnectedClients to force server updates
Fixes Pryaxis#2934
Metratrj added a commit to Metratrj/TShock that referenced this issue Feb 1, 2024
Add hook for UpdateConnectedClients to force server updates
Fixes Pryaxis#2934
@Metratrj Metratrj linked a pull request Feb 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed This is a confirmed issue Contribution Wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants