[Build 2024091704-4.3] salt fails with "No top file or master_tops data matches found"

[marmarek]

Observation

openQA test in scenario qubesos-4.3-update-x86_64-system_tests_guivm_vnc_gui_interactive@64bit fails in
update_guivm

local:
----------
          ID: states
    Function: no.None
      Result: False
     Comment: No Top file or master_tops data matches found. Please see master log for details.
     Changes:   

Summary for local
------------
Succeeded: 0
Failed:    1
------------
Total states run:     1
Total run time:   0.000 ms
DOM0 configuration failed, not continuing

qubesctl state.show_highstate fails too

Test suite description

Reproducible

Fails since (at least) Build 2024091704-4.3 (current job)

One of recent dom0 updates broke this (either from Qubes or from Fedora) - it worked a week ago. A packages diff is available at https://openqa.qubes-os.org/tests/112779#investigation

Expected result

Last good: 2024091004-4.3 (or more recent)

Further details

Always latest result in this scenario: latest

[marmarek]

This change is to blame: python/cpython#85110, it's included in Python 3.13rc2 which just landed in Fedora 41.

Old behavior:

>>> urllib.parse.urlunparse(("file", "", "top.sls", "", "", ""))
'file:///top.sls'

New behavior:

>>> urllib.parse.urlunparse(("file", "", "top.sls", "", "", ""))
'file:top.sls'

Technically, I think the latter might be more correct. But it still breaks salt's expectations.

[marmarek]

Upstream report: saltstack/salt#66898

[qubesos-bot]

Automated announcement from builder-github

The package salt has been pushed to the r4.3 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bookworm-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The package salt has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bookworm-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

[marlox-ouda]

I have also the same issue on Qubes Os 4.2.3 with fedora-40-xfce as disposable management vm. It runs python version 3.12.6 where the urlunparse change has also landed (the PR is here: python/cpython#123188).

Same patch applies on it.

[andrewdavidwong]

@marlox-ouda: Just to confirm, you're saying that you're still experiencing this bug even after applying the updates from the testing repo listed above? In other words, the updates that are supposed to fix this bug do not actually fix it for you, correct?

[marlox-ouda]

Sorry. I have not tested it from testing. I was confused by mentionned python version and Qubes Os release 4.3.

But, the patch applies on fc40 and apply on the salt package before it lands on site-packages, so it should work.
I will test it tomorrow.

[marlox-ouda]

Tested today:

• updated fedora-40 from qubes-templates-itl-testing: /usr/lib/python3.12/site-packages/salt/utils/url.py is not patched. So salt fails. File is managed by salt package with version 3006.8-1.fc40.
• updated debian-12-xfce from qubes-templates-itl-testing: /usr/lib/python3/dist-packages/salt/utils/url.py is not patched. So salt fails on issue Debian template doesn't work as default-mgmt-dvm with Salt  #9328, but once patched with if 0: […] (see the issue), it works because python version is 3.11 and urllib was not patched on this version. File is managed by salt package with version 3006.5-1+deb12u1

I do not understand yet why I cannot get salt version 3006.9-2.fc40 (as I see in current-testing repository) for fedora. I will look for this side issue.
There is not salt package in the current repository.

[marlox-ouda]

Ok. I got it. qubes-templates-itl-testing fedora-40 template has not enabled qubes-vm-r4.2-current-testing (in /etc/yum.repos.d/qubes-r4.repo).
With this one enabled, I successfully retrieved salt package with version 3006:9-2.fc40 that applies the patch and it works as expected.

[andrewdavidwong]

Re-closing as completed. If anyone believes this issue is not yet completed, or if anyone is still affected by this issue, please leave a comment, and we'll be happy to reopen it. Thank you.

[qubesos-bot]

Automated announcement from builder-github

The package salt has been pushed to the r4.2 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update