Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Picker: Focus on the Calendar Icon fails to meet minimum required color contrast of 3:1 for visual focus outlines. #4133

Open
achuth2912 opened this issue Sep 27, 2024 · 3 comments

Comments

@achuth2912
Copy link

OpenUI5 version: 1.127.0

Browser/version (+device/version): Google Chrome 128.0.6613.138

Any other tested browsers/devices(OK/FAIL):

URL (minimal example if possible): https://ui5.sap.com/#/entity/sap.m.DatePicker/sample/sap.m.sample.DatePicker

User/password (if required and possible - do not post any confidential information here):

Steps to reproduce the problem:

  1. Focus on the DatePicker Icon

What is the expected result?
Focus outline around all focusable elements must be distinct and pass a minimum of 3:1 Color contrast against its background.

What happens instead?
Color contrast fails with 1.6:1 ratio

Any other information? (attach screenshot if possible)
Screenshot 2024-09-27 at 3 14 39 PM

@MapTo0
Copy link
Member

MapTo0 commented Sep 27, 2024

hey @achuth2912

The icon in any input field could not be focused.
I am not sure where is the focused placed in your example.
Could you please provide steps to reproduce?

Best Regards,
Martin

@achuth2912
Copy link
Author

cca_fails_calendar_Icon

When we open the calendar using the Keyboard shortcut the Color contrast around icon fails.

@LidiyaGeorgieva
Copy link
Contributor

Hello @achuth2912 ,

In your last comment I see that the focus is inside the Calendar on date "11". And the focus color is correct.
The calendar icon is inside button, which is not focused. The outline of this button is decorative and do not need to fulfill color contrast ratio.
I see no issue here.

Regards,
Lidiya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants