Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins/jenkins-job-trigger HTTP failure should not be silent #2681

Open
JanZerebecki opened this issue Aug 24, 2018 · 2 comments
Open

jenkins/jenkins-job-trigger HTTP failure should not be silent #2681

JanZerebecki opened this issue Aug 24, 2018 · 2 comments
Labels

Comments

@JanZerebecki
Copy link
Contributor

After looking at #2679 it seems to me from the logs that when

server.build_job(job_name, job_parameters)
fails to create a job when the HTTPS certificate is expired it doesn't print any output. But it should. Also I'm unsure whether it correctly sets a failure exit return value.

The request is made around here: https://github.com/openstack/python-jenkins/blob/1.2.1/jenkins/__init__.py#L543
I would expect an SSLError exception or something to be printed.

@JanZerebecki
Copy link
Contributor Author

The same happens when running many jenkins-job-trigger after another, at some point Jenkins doesn't register the jobs and again this failure is silent.

@jesusaurus
Copy link
Contributor

I haven't tested it, but I think that https://review.openstack.org/599868 may do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants