Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readiness for built-in https scheme support #246

Open
2 tasks done
mbaykara opened this issue Jun 8, 2023 · 1 comment
Open
2 tasks done

Readiness for built-in https scheme support #246

mbaykara opened this issue Jun 8, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mbaykara
Copy link

mbaykara commented Jun 8, 2023

What happened?

Let's consider a scenario where a Node-RED instance is configured with enabled https for some specific reason. In this case, the hard-enabled readiness check does not receive a 200 response because the scheme is set to http. As a result, the pod will not transition to the ready state.

How can we reproduce this?

To enhance the functionality, please consider the following revisions:

  • Enable HTTPS with self-signed certificates. In my opinion, liveness and readiness should not be enabled by default. The user of the chart should have the ability to enable or disable them or further configure.
    Furthermore, it would be beneficial to take into account the following aspects:
  • Make the mount point data configurable.
  • Allow for configurability of the SecurityContext. Currently, modifying any item requires modification of all items, unless the default settings are acceptable.
  • The original Node-RED image is configured with a default user ID of 1000. What is the reasoning behind changing it to 10003?
  • When ingress is enabled with TLS, a certificate object is automatically created. However, what should be done if a self-signed certificate is required for internal usage?

It appears that this chart has been designed for a specific use case and may no longer serve a general purpose.### Helm Chart version

0.24.1

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response

@mbaykara mbaykara added the bug Something isn't working label Jun 8, 2023
@dirien
Copy link
Collaborator

dirien commented Jun 16, 2023

Hey @mbaykara,

thanks for the creating the issue and providing some valuable feedback.

Feel free start contributing your points into this codebase! This will help to make this chart an even better experience for the whole community.

On PR for each of your points would be great, as it is fast to review and incremental add new features!

@dirien dirien added enhancement New feature or request and removed bug Something isn't working labels Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants