Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up .vscode/settings.json #300

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Jun 27, 2024

Remove settings based on personal DX preference.
Workspace settings take precedence over all others, so should be minimal and functional, not based on preference.

Remove settings based on personal DX preference.
Workspace settings take precedence over all others, so should be minimal and functional, not based on preference.
@Pwuts Pwuts requested a review from ntindle June 27, 2024 19:38
@ntindle
Copy link
Member

ntindle commented Jun 27, 2024

There’s an extension that I’m looking at suggesting to add levels to this so we can suggest them and you could override locally. Imo that’s the best of both worlds. I was looking at it while trying to build a code workspace for AutoGPT

@ntindle
Copy link
Member

ntindle commented Jun 27, 2024

Problem with doing that here is there's only one place for users to modify settings on project level.

Discussed in discord and the solution from @Pwuts was to put the defaults in settings.json, forget the extension, and commit + ignore settings.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants