We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello, First of all, thank you for the excellent library.
The AllocatorVisualizer struct (both DX12 and Vulkan) are created using the new() function, which notably has no arguments. One might expect it to implement Default for this reason, but it does not. There's a clippy lint for this: https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default The Rust API guidelines recommend the same: https://rust-lang.github.io/api-guidelines/interoperability.html
new()
The text was updated successfully, but these errors were encountered:
Surprisingly src/{d3d12,vulkan}/visualizer.rs allow this lint at the top:
src/{d3d12,vulkan}/visualizer.rs
gpu-allocator/src/d3d12/visualizer.rs
Line 1 in ea9b3c8
gpu-allocator/src/vulkan/visualizer.rs
Perhaps those should be removed and the resulting clippy lints fixed? I don't see a compelling reason to omit this lint - feel free to open a PR!
Sorry, something went wrong.
No branches or pull requests
Hello,
First of all, thank you for the excellent library.
The AllocatorVisualizer struct (both DX12 and Vulkan) are created using the
new()
function, which notably has no arguments. One might expect it to implement Default for this reason, but it does not.There's a clippy lint for this: https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
The Rust API guidelines recommend the same: https://rust-lang.github.io/api-guidelines/interoperability.html
The text was updated successfully, but these errors were encountered: