-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs: icon tabs and text tabs have a different height #65624
Comments
cc @WordPress/gutenberg-components @WordPress/gutenberg-design |
If we used |
We could probably just remove the vertical padding and rely on flexbox alignment ? |
Raising a PR as per the suggestion from @ciampo in sometime. |
The Tabs component is currently heavily in flux, so please hold off on working on this until a few tweaks have been merged. I believe one of the pending PRs fixes this already. |
This will be fixed by #65387 |
Text tabs (ie.
<Tabs.Tab>text</Tabs.Tab>
) are48px
tall: https://wordpress.github.io/gutenberg/?path=/story/components-experimental-tabs--defaultIcon tabs (ie.
<Tabs.Tab><Icon /></Tabs.Tab>
) are56px
tall: https://wordpress.github.io/gutenberg/?path=/story/components-experimental-tabs--with-tab-icons-and-tooltipsShould we revise any aspects of this? It may be tricky to enforce it fully with the current set of APIs, since
Tabs
can not possibly know what its children are.The text was updated successfully, but these errors were encountered: