Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical Tab Focus Auto-select Movement is disorienting #65865

Open
2 tasks done
jeryj opened this issue Oct 3, 2024 · 6 comments · May be fixed by #65387
Open
2 tasks done

Vertical Tab Focus Auto-select Movement is disorienting #65865

jeryj opened this issue Oct 3, 2024 · 6 comments · May be fixed by #65387
Labels
[Feature] UI Components Impacts or related to the UI component system [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Comments

@jeryj
Copy link
Contributor

jeryj commented Oct 3, 2024

Description

The animated background is neat when used with an Enter Keypress or a click, but when selection happens on arrow keypress, it is visually disorienting. It feels laggy and busy.

If the tabs auto-select the category and arrow keys are used, I think we should disable the animation.

Step-by-step reproduction instructions

  • Go to the Preferences Pane
  • Go to the tabs
  • Use the arrow keys to move between the tabs
  • Animated gray background moves along with each arrow key, making it look delayed and overly busy.

Screenshots, screen recording, code snippet

Video of #65864 using fixed focus ring:

Screen.Recording.2024-10-03.at.3.35.35.PM.mov

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@jeryj jeryj added [Feature] UI Components Impacts or related to the UI component system [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components [Type] Bug An existing feature does not function as intended labels Oct 3, 2024
@jeryj
Copy link
Contributor Author

jeryj commented Oct 3, 2024

@DaniGuardiola @ciampo - What do you think?

@DaniGuardiola
Copy link
Contributor

The animation already respects the "reduced motion" setting, I wonder if that'd be enough. I do agree with selectOnMove it could potentially be a bit too much even for those that do not normally want to reduce motion, though I think it'd be a bit tricky to implement.

@WordPress/gutenberg-design thoughts?

@jasmussen
Copy link
Contributor

If we can't/won't animate the focus-ring, would it be an option to use focus-visible to omit the animation if you're keyboarding? A bit of the inverse, but it's a first question to ponder.

@DaniGuardiola DaniGuardiola linked a pull request Oct 4, 2024 that will close this issue
@DaniGuardiola
Copy link
Contributor

Here's what I did: #65387 (comment)

Let me know what you think.

@ciampo
Copy link
Contributor

ciampo commented Oct 4, 2024

I like it, and I think it aligns with @jasmussen 's preferred option.

@jeryj , what do you think?

@jeryj
Copy link
Contributor Author

jeryj commented Oct 4, 2024

That's much better! I hadn't considered that option. I tested it with keyboard in the preferences pane and it feels really smooth now. Thank you for addressing it! I would consider this fixed when #65387 lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants