Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search field or typeahead on the main page #62

Closed
patrickakk opened this issue Feb 22, 2023 · 14 comments
Closed

Add search field or typeahead on the main page #62

patrickakk opened this issue Feb 22, 2023 · 14 comments
Assignees
Labels
done Development and review process finished. Ready for release - Status of issue FeatureRequest New feature request - Kind of issue frontend Front End - Part of application InReview Request from dev to test and give feedback on the implementation of the issue - Status of issue
Milestone

Comments

@patrickakk
Copy link
Contributor

patrickakk commented Feb 22, 2023

@IvdL22 @PixlTracer Here I'm adding the new idea which came up during the meeting today:

On the main page, where the overview of all the courses is listed, a search field or typeahead could be added to make it easier for users to search for a course and improve the user experience.

@patrickakk patrickakk added FeatureRequest New feature request - Kind of issue frontend Front End - Part of application labels Feb 22, 2023
@patrickakk patrickakk self-assigned this Feb 22, 2023
@patrickakk patrickakk added this to the mai23 milestone Apr 19, 2023
@patrickakk patrickakk added the indev Currently in development – Status of issue label Apr 19, 2023
@patrickakk
Copy link
Contributor Author

Searchbar

230419_searchbar_clean

Searchbar with results

230419_searchbar_with_results

@PixlTracer
Copy link

yes!! 🥳
looking forward to this feature!!

@patrickakk
Copy link
Contributor Author

patrickakk commented Apr 25, 2023

@PixlTracer @IvdL22
Can you please fix the name of this course: https://dhcr.clarin-dariah.eu/courses/view/389
(Note: changes should be made in production)

The name contains the character " which causes the course to be shown on top of search results instead of sorted after other courses, which start with B

Please write a line when it's fixed.

@IvdL22
Copy link

IvdL22 commented Apr 25, 2023

@IvdL22 I have fixed it but forgot to do it in production. Does that pose a major problem?

@patrickakk
Copy link
Contributor Author

@IvdL22 It doesn't cause a problem. It just means you have to do it again ;) (now in production), because:

  • Production is what is shown to the public
  • Production DB is leading, which means it's copied from time to time to test and dev and the data there will be overwritten.

Can you write a line here when it's fixed?

@patrickakk patrickakk removed the indev Currently in development – Status of issue label May 6, 2023
@patrickakk
Copy link
Contributor Author

(the course name specified above is fixed)

@patrickakk patrickakk removed their assignment May 8, 2023
@patrickakk patrickakk added the InReview Request from dev to test and give feedback on the implementation of the issue - Status of issue label May 8, 2023
@patrickakk
Copy link
Contributor Author

The required unique on course name and institution have been implemented.
Development finished.
Implemented in 2023-04.

@IvdL22 @PixlTracer Can you review this new feature?

Note: Before releasing this version into production, we need to solve all the conflicts in the production database, as addressed here: #59 (comment)

@IvdL22
Copy link

IvdL22 commented May 10, 2023

@patrickakk Tested the feature and it seems fine.

@patrickakk patrickakk added Blocked Blocked by other action – Status of issue and removed InReview Request from dev to test and give feedback on the implementation of the issue - Status of issue labels May 11, 2023
@patrickakk
Copy link
Contributor Author

Waiting for the conflicts of course names to be solved (see above), then this issue can be closed.

@PixlTracer
Copy link

commented in issue 59; for consistency I am pasting my thought on the search bar here again:

when using the search bar, a user is entering certain keywords - why not output a list (similar to when applying filters) of all the courses that match the keyword? so we don't need to check the course-names for their uniqueness...

very much looking forward to the deployment of the new feature!

@patrickakk
Copy link
Contributor Author

@PixlTracer

when using the search bar, a user is entering certain keywords - why not output a list (similar to when applying filters) of all the courses that match the keyword? so we don't need to check the course-names for their uniqueness...

I'm not sure which part of the application you mean. Is it the main page where the new search bar is visible? Here: https://test-dhcr.clarin-dariah.eu/

Currently the you can search in both course name and institution name or a part of it. Can you explain what you mean?

patrickakk added a commit that referenced this issue Jun 22, 2023
@patrickakk
Copy link
Contributor Author

@IvdL22 @PixlTracer

All conflicting course names are changed/solved. As well I've added the course type to the searchbar, because there are courses with identical course name and institution name, that only can be distinguished by having the course type added.

The result can be found here:
https://test-dhcr.clarin-dariah.eu/

A nice test case could be to search for "Digital Humanities - Universität Basel", since this didn't work before.

Can you review this and change the label to Done if satisfied?

@patrickakk patrickakk added InReview Request from dev to test and give feedback on the implementation of the issue - Status of issue QuickCheck and removed Blocked Blocked by other action – Status of issue labels Jun 22, 2023
@IvdL22
Copy link

IvdL22 commented Jun 23, 2023

@patrickakk It works fine, much appreciated!

@IvdL22 IvdL22 closed this as completed Jun 23, 2023
@IvdL22 IvdL22 added the done Development and review process finished. Ready for release - Status of issue label Jun 23, 2023
@patrickakk patrickakk reopened this Jun 27, 2023
@patrickakk
Copy link
Contributor Author

Implemented in 2023-04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Development and review process finished. Ready for release - Status of issue FeatureRequest New feature request - Kind of issue frontend Front End - Part of application InReview Request from dev to test and give feedback on the implementation of the issue - Status of issue
Projects
None yet
Development

No branches or pull requests

3 participants