Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Leaflet to latest version 1.9.4 #66

Open
patrickakk opened this issue Apr 3, 2023 · 2 comments
Open

Migrate Leaflet to latest version 1.9.4 #66

patrickakk opened this issue Apr 3, 2023 · 2 comments
Labels
admin Admin - Part of application bug Something isn't working - Kind of issue frontend Front End - Part of application todo Ready to start development - Status of issue
Milestone
Someday

Comments

@patrickakk
Copy link
Contributor

patrickakk commented Apr 3, 2023 •
edited
Loading

The map on the main page currently uses leaflet 1.5.1 which was released on 2019-05-08. We might want to consider migrating to the latest version.

Currently two other issues seem to be related to this:
@patrickakk patrickakk added frontend Front End - Part of application admin Admin - Part of application labels Apr 3, 2023
@patrickakk patrickakk self-assigned this Apr 3, 2023
@patrickakk patrickakk mentioned this issue Apr 5, 2023
Closed
@patrickakk patrickakk added the bug Something isn't working - Kind of issue label May 11, 2023
@patrickakk patrickakk added this to the September 2023 milestone May 11, 2023
@patrickakk patrickakk added the todo Ready to start development - Status of issue label May 11, 2023
@patrickakk
Copy link
Contributor Author

Update:
The latest version is Leaflet 1.9.4 released on May 18, 2023.

@patrickakk patrickakk changed the title Migrate Leaflet to latest version 1.9.3 Migrate Leaflet to latest version 1.9.4 Aug 2, 2023
@patrickakk patrickakk removed this from the September 2023 milestone Sep 6, 2023
@patrickakk
Copy link
Contributor Author

The files are included in the application repository instead of using a CDN or package manager.

When replacing the files, it breaks. Needs more time to investigate.

The most important thing, changing to new API keys (see other issue) has been done.

Removed from milestone. Reason: too much other things to do right now.

@patrickakk patrickakk removed their assignment Sep 6, 2023
@vronk vronk mentioned this issue Dec 6, 2023
Open
@vronk vronk added this to the Someday milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
admin Admin - Part of application bug Something isn't working - Kind of issue frontend Front End - Part of application todo Ready to start development - Status of issue
Projects
None yet
Milestone
Someday
Development

No branches or pull requests
2 participants
@vronk @patrickakk