Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard certificates may be persisted under the wrong name #49

Open
null-dev opened this issue Dec 31, 2021 · 0 comments
Open

Wildcard certificates may be persisted under the wrong name #49

null-dev opened this issue Dec 31, 2021 · 0 comments

Comments

@null-dev
Copy link

I'm running into a case where if I pass a non-wildcard name into new_order as the primary name but include a wildcard name in the aliases, the cert is persisted under the wildcard name instead of the non-wildcard primary name. I suspect this is happening because:

Section 7.4 of the ACME spec states that:

Clients MUST NOT make any assumptions about the sort order of
"identifiers" or "authorizations" elements in the returned order
object.

This means that the primary_name that I pass into new_order might not actually be used to persist the cert here as the order of the domains could change:

let primary_name = self.order.api_order.domains()[0].to_string();

The spec is a bit confusing because it also says the following in Section 7.1.3:

The elements of the "authorizations" and "identifiers" arrays are
immutable once set. The server MUST NOT change the contents of
either array after they are created. If a client observes a change
in the contents of either array, then it SHOULD consider the order
invalid.

I believe they just mean that entries can't be added/deleted though and that the ordering of entries can still change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant