Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing openssl #57

Open
joepio opened this issue Feb 2, 2023 · 3 comments
Open

Consider changing openssl #57

joepio opened this issue Feb 2, 2023 · 3 comments

Comments

@joepio
Copy link

joepio commented Feb 2, 2023

Hi there! Thanks for creating and maintaining this.

Since this crate depends on openssl, it is not fully self-contained. I've already encoutered a bunch of problems because of either lacking or mismatching openssl versions.

I don't think openssl is needed. I suppose a crate like ring has most of the crypto capabilities that we need here. Perhaps rustls could also help?

Not sure if I can help here, but wanted to drop the request anyways!

@algesten
Copy link
Owner

algesten commented Feb 2, 2023

I think openssl is mainly used for creating private keys and certificate requests. https://github.com/algesten/acme-lib/blob/master/src/cert.rs

There can definitely be better ways of doing that. PRs welcome!

@joepio joepio changed the title Consider changing openssl for ring or rustls Consider changing openssl Feb 2, 2023
@joepio
Copy link
Author

joepio commented Feb 4, 2023

I tried making a start for migrating OpenSSL to Ring, but it looks like ring doesn't have support for PEM encoding. Since the PEM encoding is used everywhere in this repo, I'm not quite sure how to deal with this. Perhaps simply using the pem crate?

Anyways, it looks like a bit too much new stuff for me to dive into now. Sorry.

@Jaffa-Cakes
Copy link

I may take a look into swapping things over to another self-contained crate if I have the time, would a pull request doing this be accepted @joepio?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants