Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render pass with no attachments causes subtraction underflow. #278

Open
sadmac7000 opened this issue Apr 28, 2020 · 1 comment
Open

Render pass with no attachments causes subtraction underflow. #278

sadmac7000 opened this issue Apr 28, 2020 · 1 comment

Comments

@sadmac7000
Copy link

sadmac7000 commented Apr 28, 2020 •
edited
Loading

https://github.com/amethyst/rendy/blob/master/graph/src/node/render/pass.rs#L718

The subtraction here underflows when attachments.len() == 0. This causes a crash in developer mode.
@zakarumych
Copy link
Member

This use-case is not supported by RenderPassNodeBuilder because it must figure-out framebuffer dimensions. I guess an error would be more appropriate then underflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sadmac7000 @zakarumych