Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

headers don't get written if no content or status is written #38

Open
UnquietCode opened this issue Nov 8, 2020 · 1 comment
Open

headers don't get written if no content or status is written #38

UnquietCode opened this issue Nov 8, 2020 · 1 comment

Comments

@UnquietCode
Copy link

UnquietCode commented Nov 8, 2020 •
edited
Loading

The golang http server will write out on close, just in case nothing was written. Could the End() method be changed to call Write([]byte{}) so that it will trigger the headers and status OK being written?

This is using v2.0.0 of the library.
UnquietCode added a commit to UnquietCode/gateway that referenced this issue Nov 9, 2020
@UnquietCode
apex#38 ensure that headers and status code get written, even if noth…
ffb4021 
…ing was ever written. This better aligns with the golang http package's own behavior to write on close.
@UnquietCode UnquietCode mentioned this issue Nov 9, 2020
Open
@UnquietCode
Copy link
Author

UnquietCode commented Nov 9, 2020 •
edited
Loading

I've just sent a PR with an example of what I mean. 👍 #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@UnquietCode