Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Support for bazel coverage #125

Open
gregjacobs opened this issue Feb 20, 2024 · 0 comments
Open

[FR]: Support for bazel coverage #125

gregjacobs opened this issue Feb 20, 2024 · 0 comments
Labels
enhancement New feature or request untriaged Requires traige

Comments

@gregjacobs
Copy link

gregjacobs commented Feb 20, 2024

What is the current behavior?

It seems that rules_jasmine doesn't support code coverage via bazel coverage like the js_test rule does.

The *.instrumented-files file in the output tree always comes up empty. I think this is because rules_jasmine doesn't call coverage_common.instrumented_files_info() and return its provider like js_test does here: https://github.com/aspect-build/rules_js/blob/v1.37.1/js/private/js_binary.bzl#L571

Describe the feature

bazel coverage on a jasmine_test target should report lcov coverage just like js_test does :)

We should essentially see a bazel-testlogs/package/target/coverage.dat file with the lcov report for the test, and the combined lcov report in bazel-out/_coverage/_coverage_report.dat when running bazel coverage //package:target

@gregjacobs gregjacobs added the enhancement New feature or request label Feb 20, 2024
@github-actions github-actions bot added the untriaged Requires traige label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged Requires traige
Projects
Status: No status
Development

No branches or pull requests

1 participant