From a8a7b9d7842a1f3d7bb6eff43fae26db81359ccc Mon Sep 17 00:00:00 2001 From: Greg Magolan Date: Fri, 27 Oct 2023 13:45:01 +0200 Subject: [PATCH] fix: fixup failing assert_contains test --- .aspect/workflows/config.yaml | 3 +++ jest/private/jest_test.bzl | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.aspect/workflows/config.yaml b/.aspect/workflows/config.yaml index ba0f1bc..53c94b4 100644 --- a/.aspect/workflows/config.yaml +++ b/.aspect/workflows/config.yaml @@ -4,5 +4,8 @@ tasks: buildifier: gazelle: test: + bazel: + flags: + - --instrumentation_filter=-//jest/tests/fixed_args:fixed_args_test coverage: true upload_test_logs: executed diff --git a/jest/private/jest_test.bzl b/jest/private/jest_test.bzl index 9ba6e81..4f8c0ce 100644 --- a/jest/private/jest_test.bzl +++ b/jest/private/jest_test.bzl @@ -84,7 +84,8 @@ def _impl(ctx): "--config", # quote the path since it might have special chars such as parens. # quoting ensures that the shell doesn't do any globbing or splitting. - "'" + paths.join(unwind_chdir_prefix, generated_config.short_path) + "'", + # NB: intentionally use double quotes + "\"" + paths.join(unwind_chdir_prefix, generated_config.short_path) + "\"", ]) if ctx.attr.log_level == "debug": fixed_args.append("--debug")