-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension defaults cause other bazel commands to hang on a significantly large repos #395
Comments
The long-term direction would be using a separate output base for the However, it is of course annoying that this extension currently blocks by default for large repositories... Even worse, there is no way for the user to easily see what's going on. I am not yet sure what a good "onboarding experience" would be here My current idea would be: |
I thought a bit more about this aspect
Instead of eagerly loading the tree of Bazel targets, we should probably only run the |
(Adding this here as I believe this issue relates to our slack discussion @vogelsgesang). The targets tree/querying portion is another potential candidate for an enable/disable setting. In our case we have a larger monorepo and users would need to know to adjust this scope to match their projects, or they'll get a very large query (in our case we just added a placeholder pattern that returns nothing). |
I beleive this Bazel extension is running a very expensive query. This is fine on a small repo, but on a large monorepo this basically prevents the user from running any other bazel commands till this is done. Specifically I found the process to be running this
The
...
in there will take forever on a larger repo. I believe the culprit is this line https://github.com/bazelbuild/vscode-bazel/blob/e5c95e4567a80c82ada48031c9fde5561fc7c957/src/bazel/bazel_query.ts#L64This could be improved by adding this flag https://bazel.build/reference/command-line-reference#flag--preemptible by default.
While I do understand the default setting is
...
, I'd love to understand better what the recommendation is for larger repos.The text was updated successfully, but these errors were encountered: