Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/wildfly] misconfigured mgmtIngress annotations #29787

Open
emilianosantucci opened this issue Oct 6, 2024 · 2 comments · May be fixed by #29819
Open

[bitnami/wildfly] misconfigured mgmtIngress annotations #29787

emilianosantucci opened this issue Oct 6, 2024 · 2 comments · May be fixed by #29819
Assignees
Labels
tech-issues The user has a technical issue about an application triage Triage is needed wildfly

Comments

@emilianosantucci
Copy link

Name and Version

bitnami/wildfly 15.2.1

What architecture are you using?

arm64

What steps will reproduce the bug?

  1. helm install wildfly bitnami/wildfly --version 15.2.1 -f values.yaml

Are you using any custom parameters or values?

exposeManagementConsole: true
ingress:
  enabled: true
  hostname: wildfly.192.168.70.2.nip.io
  annotations:
    nginx.ingress.kubernetes.io/proxy-body-size: 10m
mgmtIngress:
  enabled: true
  hostname: wildfly-management.192.168.70.2.nip.io
  annotations:
    nginx.ingress.kubernetes.io/proxy-body-size: 100m

What is the expected behavior?

  • ingress accept upload with max size 10m
  • mgmtIngress accept upload with max size 100m

What do you see instead?

Created ingress not inherit annotations added to values.yaml.

Additional information

Workaround used:

Use commonAnnotations into values.yaml as below:

commonAnnotations:
  nginx.ingress.kubernetes.io/proxy-body-size: 100m

I know it is not the best choice (it set this annotations on all components created) but allow me to load WAR with a size greater than 1Mb.

Hint for the resolutions:

I'm not a Helm master but I think the issue is on this template at row 19:

  • Is:
    {{- $annotations := include "common.tplvalues.merge" ( dict "values" ( list .Values.persistence.annotations .Values.commonAnnotations ) "context" . ) }}
  • Should be:
    {{- $annotations := include "common.tplvalues.merge" ( dict "values" ( list .Values.mgmtIngress.annotations .Values.commonAnnotations ) "context" . ) }}
@emilianosantucci emilianosantucci added the tech-issues The user has a technical issue about an application label Oct 6, 2024
@github-actions github-actions bot added the triage Triage is needed label Oct 6, 2024
@javsalgar javsalgar changed the title [WILDFLY]: misconfigured mgmtIngress annotations [bitnami/wildfly]: misconfigured mgmtIngress annotations Oct 7, 2024
@javsalgar javsalgar changed the title [bitnami/wildfly]: misconfigured mgmtIngress annotations [bitnami/wildfly] misconfigured mgmtIngress annotations Oct 7, 2024
@javsalgar
Copy link
Contributor

Hi!

Thank you so much for spotting it! Indeed, the issue is exactly as you mentioned. As you discovered it, would you like to submit a PR changing that line of the ingress file?

emilianosantucci added a commit to emilianosantucci/bitnami-charts that referenced this issue Oct 8, 2024
Change "persistence" reference annotations to "mgmtIngress"

Signed-off-by: Emiliano Santucci <[email protected]>
@emilianosantucci
Copy link
Author

Hi @javsalgar,
thank you for the feedback, I just open a PR for the fix.

Please feel free to give any advice about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-issues The user has a technical issue about an application triage Triage is needed wildfly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants