Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin request for protoc-gen-go_{cli,gapic} #1305

Open
mfridman opened this issue Jun 18, 2024 · 2 comments
Open

Plugin request for protoc-gen-go_{cli,gapic} #1305

mfridman opened this issue Jun 18, 2024 · 2 comments
Labels
Feature New feature or request

Comments

@mfridman
Copy link
Member

Mandatory

Where is the source code for the plugin?

https://github.com/googleapis/gapic-generator-go/tree/main/cmd

Optional

Does the plugin have a valid semver version?

Yes.

https://github.com/googleapis/gapic-generator-go/releases

Latest as of this writing is v0.43.1.

Does the plugin have a dependency on another plugin?

Not sure.

Does the output of this plugin depend on any other external libraries?

Not sure.

@mfridman mfridman added the Feature New feature or request label Jun 18, 2024
@bufdev
Copy link
Member

bufdev commented Jun 26, 2024

Doesn't this plugin function by reading local disk if I remember? If so, we can't add it as of now, can you confirm @mfridman ?

@mfridman
Copy link
Member Author

mfridman commented Jul 5, 2024

They made some significant changes in that project, I took a quick peek and most of the os calls are gated by an option. For example,

https://github.com/googleapis/gapic-generator-go/blob/134f862b5a05028c5e1af4b55ad213bf6ce9757d/internal/gengapic/generator.go#L137-L141

I'll timebox this and see if I can get a simple project to work without local disk.

TL; DR - Both plugins might work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants