Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CringeMDB support? #61

Closed
v0iden opened this issue Mar 20, 2022 · 4 comments
Closed

CringeMDB support? #61

v0iden opened this issue Mar 20, 2022 · 4 comments

Comments

@v0iden
Copy link

v0iden commented Mar 20, 2022

CringeMDB is a website that displays information on whether a movie is family friendly or not. It is based on TMDB and community maintained. Would this be possible to add to the extension?

Here's an example: https://cringemdb.com/movie/oldboy-2013

@buzz
Copy link
Owner

buzz commented Jul 16, 2022

CringeMDB doesn't expose the search through a regular POST or GET request but relies on an API. We would need to implement #9 first to make it work.

@v0iden
Copy link
Author

v0iden commented Jul 16, 2022

can't you just generate a URL and hope it is listed on cmdb? as a temporary solution at least?

@buzz
Copy link
Owner

buzz commented Jul 16, 2022

Well, you would somehow need to go from the fields parsed from the IMDb page (title, year) to a working CringeMDB URL, e.g.
title=oldboy year=2013https://cringemdb.com/movie/oldboy-2013

To be able to do this in a reliable and flexible way, you'd want some rule based text transforms, I suppose. They seem to replace special characters and blanks with dashes, etc. PR welcome!

Before heading down that road it might be better to go with a fancy descriptive API adapter for the true search functionality.

@buzz
Copy link
Owner

buzz commented Dec 15, 2022

Closed due to inactivity.

@buzz buzz closed this as completed Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants