Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slider has 0 height on Android with new architecture enabled #652

Open
vonovak opened this issue Oct 4, 2024 · 0 comments
Open

slider has 0 height on Android with new architecture enabled #652

vonovak opened this issue Oct 4, 2024 · 0 comments
Labels
bug report Something isn't working

Comments

@vonovak
Copy link

vonovak commented Oct 4, 2024

Description

[android only] While testing the project (I tested from the main branch) with new architecture (RN 0.75) I experienced 2 issues:

  1. project does not build following fix: floating number problem on android #649 because the codegen-generated interface expects floats instead of doubles - that's easy to fix
  2. slider cannot be interacted with (dragged) because it has zero height; see image
Screenshot 2024-10-05 at 0 00 02

This seems like a regression since #589 which was solving the same problem.
I'd be happy to submit a PR instead of an issue but I believe you'll be much better at figuring it out :).

Reproducible Demo

Please see the example at https://github.com/vonovak/react-native-slider/tree/fix/new-arch-issues/new-example

It's a fork of this repo, with new example added which uses https://github.com/microsoft/react-native-test-app (RNTA)

The example app was generated with npx --package react-native-test-app@latest init and then I modified metro.config.js and react-native.config.js to make it all work. Then I copied src directory from the existing example.

Feel free to integrate that into the repo, RNTA is an amazing tool :).

@vonovak vonovak added the bug report Something isn't working label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant