Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KServe transitive dependency license issue #183

Open
Eta0 opened this issue Apr 25, 2023 · 1 comment · May be fixed by #184
Open

KServe transitive dependency license issue #183

Eta0 opened this issue Apr 25, 2023 · 1 comment · May be fixed by #184
Labels
bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@Eta0
Copy link
Contributor

Eta0 commented Apr 25, 2023

We currently use kserve (a.k.a. kfserving in older versions) as a dependency for the following online-inference examples:

KServe issue #2683 notes that their (previous) logging dependency table-logger is exclusively GPL-licensed in all of its PyPI releases.

  • table-logger switched to an MIT license in a commit in February, with the rest of its codebase in an identical state to its latest PyPI release (0.3.6). Nonetheless, the PyPI distribution that we use technically only embeds the GPLv2 license. They have not released anything on PyPI with the updated license.
  • kserve moved away from table-logger entirely in favour of tabulate (MIT-licensed) in kserve release 0.10.1.

Since this repository is not GPL-licensed, for compliance, we should either:

  • Pin the table-logger transitive dependency in our requirements.txt files alongside older kserve/kfserving dependencies to the latest Git version (git+https://github.com/AleksTk/table-logger@3cab68c59062ce4d9cb3b667f64e83a23789bf63), which embeds the MIT license, or
  • Update kserve dependencies to at least version 0.10.1

In each of the affected examples, and rebuild their associated Docker images.

@Eta0 Eta0 added bug Something isn't working dependencies Pull requests that update a dependency file labels Apr 25, 2023
@Eta0 Eta0 linked a pull request Apr 25, 2023 that will close this issue
@Eta0
Copy link
Contributor Author

Eta0 commented Apr 25, 2023

PR for an initial fix opened at #184.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant