Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache on-demand proxies #130

Open
briancavalier opened this issue Jul 18, 2013 · 1 comment
Open

Cache on-demand proxies #130

briancavalier opened this issue Jul 18, 2013 · 1 comment

Comments

@briancavalier
Copy link
Member

Wire doesn't create a proxy for a component it didn't create. So, sometimes, it has to create a proxy on-demand, when a plugin asks for it. Prime example: DOM nodes can be pulled into the current context via reference resolver. Since wire didn't create the DOM node, it doesn't proxy it by default. If another component uses the on facet (via wire/on) to connect to an event on the DOM node, wire/on asks for the node's proxy, and wire has to create it right then. Currently, we don't retain the association between the node and the just-created proxy. Perhaps we should.

@scothis
Copy link
Member

scothis commented Jul 18, 2013

If for some reason the creation/destruction of the DOM node isn't in sync with the wire spec, this could create a memory leak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants