Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"danger-swift edit" no longer works with Swift 5.8 due to the removal of generate-xcodeproj #582

Open
jagdeep-manik opened this issue Apr 5, 2023 · 5 comments

Comments

@jagdeep-manik
Copy link

jagdeep-manik commented Apr 5, 2023

Reproduction Steps:

  • Download Xcode 14.3 and make sure your command line tools use Xcode 14.3 (Xcode > Settings > Command Line Tools, or use xcode-select -s)
  • Navigate to a project with a Dangerfile
  • In terminal, enter danger-swift edit

You'll receive an error along the lines of:
ERROR: commandFailed(command: "cd /Users/<username>/.danger-swift/Scripts/Cache/-Users-<username>-Documents-<project>-Dangerfile && /usr/bin/env xcrun --sdk macosx swift package generate-xcodeproj --xcconfig-overrides /var/folders/31/jcw4hfyd6dv_x87s3z8kd9m40000gp/T/config.xcconfig", exitCode: 64, stdout: "", stderr: "error: Unknown subcommand or plugin name \'generate-xcodeproj\'\nUsage: swift package <options> <subcommand>\n See \'package -help\' for more information.\n")

I couldn't find too much information on the command being removed, apart from this comment:
swiftlang/swift-package-manager#6640

But if you use swift 5.7.1 tools and run swift help package generate-xcodeproj you'll receive a message saying OVERVIEW: Generates an Xcode project. This command will be deprecated soon., whereas if you use swift 5.8 tools and run swift help package generate-xcodeproj it'll just list the normal "help" message and generate-xcodeproj is no longer listed. So it seems like it was indeed removed.

@orta
Copy link
Member

orta commented Apr 5, 2023

See: #566 for WIP on fixing this

@pjechris
Copy link

@orta any chance to have a new release soon? can't start testing danger-swift because latest release (3.16.0) does not contain the fix. 🙏

@orta
Copy link
Member

orta commented Jun 29, 2023

/cc @f-meloni

@f-meloni
Copy link
Member

f-meloni commented Jul 1, 2023

I have just released 3.17.0, let me know if it works as expected :)

@pjechris
Copy link

pjechris commented Jul 5, 2023

@f-meloni it's working, thanks a lot 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants