Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config.ini location which is not tied to a specific version #35080

Open
jcrben opened this issue Aug 5, 2024 · 7 comments · May be fixed by dbeaver/equinox#1 or #35799
Open

Add config.ini location which is not tied to a specific version #35080

jcrben opened this issue Aug 5, 2024 · 7 comments · May be fixed by dbeaver/equinox#1 or #35799

Comments

@jcrben
Copy link

jcrben commented Aug 5, 2024

Description

The wiki page https://github.com/dbeaver/dbeaver/wiki/How-to-set-a-variable-if-dbeaver.ini-is-read-only says to look up the directory based upon Help -> Installation Information -> Configuration -> org.osgi.framework.storage.

However, as you can see in that screenshot, this spits out a directory inside install-data which is nested inside a version-specific folder. I tried this on both Windows and Linux and while it doesn't print a directory inside .eclipse now (it's in the proper workspace location: https://github.com/dbeaver/dbeaver/wiki/Workspace-location)

I'm sure you can understand why I'd rather not put a config file into a version-specific directory - can we just use the workspace6 directory for config.ini?

As another note - and maybe for another issue - it would be nice if there was a documentation page - https://github.com/dbeaver/dbeaver/wiki/Configuration-files-in-DBeaver would fit well - which mentioned the other files that you can use to configure - most notably workspace6/.metadata/.plugins/org.eclipse.core.runtime./.settings/org.jkiss.dbeaver.core.prefs - ideally this can be contrasted w/ the config.ini - I believe there are some fields that overlap and others that do not? For example I couldn't get config.ini to recognize the ui.show.tip.of.the.day.on.startup config but I believe you can put -Djavax.net.ssl.trustStore into the eclipse configs and into config.ini (where you omit the -D).

Note that https://github.com/dbeaver/dbeaver/wiki/Configuration-files-in-DBeaver doesn't even mention config.ini which I consider to be a gap that should be fixed.

My use case is to persist these configs into a dotfiles repo so I can easily restore my preferences.

DBeaver Version

Community Edition 24.1.3

Operating System

Windows 10

Database and driver

N/A

Steps to reproduce

No response

Additional context

No response

@jcrben
Copy link
Author

jcrben commented Aug 7, 2024

Another thing I noticed which really does belong in a separate issue: I couldn't get the max heap size https://github.com/dbeaver/dbeaver/wiki/Command-Line configuration to work in my config.ini

I tried putting just this in my config.ini:

-vmargs
-Xmx4000m

and it didn't take - I verified the actual max heap size using jcmd <PID> - ultimately I just passed the arguments via the cli.

@ShadelessFox
Copy link
Member

Thanks for the feature request. We can't just simply move dbeaver.ini to a shared location - it contains JVM arguments that may vary between different releases of the product. Yet, we can provide a mechanism to load JVM arguments from another file located somewhere in DBeaverData, for example.

@jcrben
Copy link
Author

jcrben commented Aug 15, 2024

@ShadelessFox what about the suggestions to improve the docs in the meantime?

@jcrben
Copy link
Author

jcrben commented Aug 15, 2024

Also you guys ship updates quite often. Another idea is to maybe have a setting which automatically copies the config.ini or jvm config file over to the next version. You can detect if there's an incompatible jvm property when you're doing the copy. That's a fair bit more work on your end tho, maybe more of a premium feature

@arhayka
Copy link
Member

arhayka commented Aug 21, 2024

Thank you for your idea, we need to explore if this is possible.

@ShadelessFox
Copy link
Member

ShadelessFox commented Oct 4, 2024

@ShadelessFox
Copy link
Member

We want to provide a means to specify extra JVM arguments via a dedicated file located in the DBeaverData folder. It will have a higher priority than the arguments defined in dbeaver.ini, allowing to override default values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment