Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTHER] PropertyFactory should be used Clones.clone #1204

Open
1 task done
aggre opened this issue Jun 10, 2022 · 1 comment
Open
1 task done

[OTHER] PropertyFactory should be used Clones.clone #1204

aggre opened this issue Jun 10, 2022 · 1 comment

Comments

@aggre
Copy link
Member

aggre commented Jun 10, 2022

What would you like to share?

Clones.clone effectively reduces the waste of redeploying the "same implementation" by leveraging the Proxy pattern.

PropertyFactory.create contains Property.sol and it calls new each time it is executed. Therefore, it consumes a lot of gas fees.

Replacing the implementation of PropertyFactory.create with Clones.clone would require the following changes:

Additional information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@aggre
Copy link
Member Author

aggre commented Jun 10, 2022

I've wrote the same issue on dev-protocol/protocol-v2#373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant