We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clones.clone effectively reduces the waste of redeploying the "same implementation" by leveraging the Proxy pattern.
Clones.clone
PropertyFactory.create contains Property.sol and it calls new each time it is executed. Therefore, it consumes a lot of gas fees.
PropertyFactory.create
Property.sol
new
Replacing the implementation of PropertyFactory.create with Clones.clone would require the following changes:
setPropertyImpl(address impl)
No response
The text was updated successfully, but these errors were encountered:
I've wrote the same issue on dev-protocol/protocol-v2#373
Sorry, something went wrong.
No branches or pull requests
What would you like to share?
Clones.clone
effectively reduces the waste of redeploying the "same implementation" by leveraging the Proxy pattern.PropertyFactory.create
containsProperty.sol
and it callsnew
each time it is executed. Therefore, it consumes a lot of gas fees.Replacing the implementation of
PropertyFactory.create
withClones.clone
would require the following changes:Property.sol
as an implementation contractsetPropertyImpl(address impl)
to store the address of the implementation contractAdditional information
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: