Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: laminas (original, original-wordmark, line, line-wordmark) #2246

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

new icon: laminas (original, original-wordmark, line, line-wordmark) #2246

wants to merge 3 commits into from

Conversation

hammad-521
Copy link

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes #2234

Link to prove your SVG is correct and up-to-date.

https://getlaminas.org/

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Aug 14, 2024
@Snailedlt Snailedlt requested review from a team, ConX, weh, Snailedlt, canaleal and lunatic-fox and removed request for a team August 14, 2024 06:49
canaleal
canaleal requested changes Aug 15, 2024
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall excellent work, just a few minor comments that have to be resolved.

icons/laminas/laminas-line.svg Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG should be scaled 128 so it can reach the edges of the viewbox.
The strokes in the SVG should also be converted into paths.

image

icons/laminas/laminas-line-wordmark.svg Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convert all strokes in this SVG into paths.

Icomoon, the tool we use to convert SVGs into font icons, requires paths to function correctly. If an SVG doesn't contain paths, it won't be converted properly and will appear empty.

image

devicon.json Outdated
"line-wordmark"
],
"font": [
"original"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add, original-wordmark, line, and line-wordmark here as all 3 can be converted into font versions.

devicon.json Show resolved Hide resolved
@hammad-521
Copy link
Author

@canaleal
Thank you for your thorough review. I've addressed all the points you raised:

  1. icons/laminas/laminas-line.svg:

    • Scaled the SVG to 128 to reach the edges of the viewbox.

  2. icons/laminas/laminas-line-wordmark.svg:

    • Converted all strokes to paths.

  3. devicon.json:

    • Added 'original-wordmark', 'line', and 'line-wordmark' to the font versions.
    • Updated the aliases section as suggested: 
      "aliases": [
  {
    "base": "original",
    "alias": "plain"
  },
  {
    "base": "original-wordmark",
    "alias": "plain-wordmark"
  }
]

I've committed these changes and pushed them to the repository. The pull request now shows 2 commits. Could you please review the changes again? Let me know if any further modifications are needed.

canaleal
canaleal previously approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work 💯
Just added another commit to fix some line artifacts on icomoon for the line SVGs.

@canaleal canaleal changed the title Add laminas icon (devicons#2234) new icon: laminas (original, original-wordmark, line, line-wordmark) Aug 17, 2024
@canaleal canaleal changed the base branch from master to develop August 23, 2024 03:05
@canaleal canaleal dismissed their stale review August 23, 2024 03:05

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canaleal canaleal canaleal approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@weh weh Awaiting requested review from weh weh was automatically assigned from devicons/devicon__reviewers

@Snailedlt Snailedlt Awaiting requested review from Snailedlt Snailedlt was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ICON REQUEST]: laminas/mezzio
3 participants
@hammad-521 @canaleal @Snailedlt