Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oxygen plugin] Fix gap annotation #36

Open
dvglc opened this issue Apr 29, 2019 · 3 comments
Open

[oxygen plugin] Fix gap annotation #36

dvglc opened this issue Apr 29, 2019 · 3 comments
Assignees
Labels
bug Something isn't working oXygen framework does not apply to anything facing externally, but to our oXygen framework

Comments

@dvglc
Copy link
Contributor

dvglc commented Apr 29, 2019

When annotating gaps ("Fehlstelle"), the plugin currently produces something à la <damage agent="ink"><gap reason="damage" resp="#DG"/></damage>, which is not valid according to our schema due to the lack of @cert. Should rather look like: <damage agent="ink"><gap reason="damage" resp="#DG" cert="high"/></damage>, for example, if the editor is sure that something is missing.

We could always add a default value (high), but I think explicitly asking the editor would be better in such (rather rare) cases.

@dvglc dvglc added the bug Something isn't working label Apr 29, 2019
@dvglc
Copy link
Contributor Author

dvglc commented Nov 28, 2019

After the update to 0.9.22, tei:gap still seems to lack @cert. I have tested this with 2 different oxygen installations and the annotation always produced the same (erroneous) outcome...

@awagner-mainz
Copy link
Member

Am I looking at the right command? In "Editorische Eingriffe" | "gap (Fehlstelle)"? Clicking on it and accepting the defaults twice ("ink" damage and "high" certainty) gives the following code:

<damage agent="ink"><gap reason="damage" resp="#AW" cert="high"/></damage>

capture_001_29112019_135214
capture_002_29112019_135306
capture_003_29112019_135341

Is that even correct? If it is, then we should find out why it's working here and not on your computers...

(Can you check if you have set the $svsal-user custom Editor variable (in "Preferences" | "Custom Editor Variables", see screenshot), and if not, if setting it changes anything in the outcome of this command?
capture_004_29112019_135920

@dvglc
Copy link
Contributor Author

dvglc commented Nov 29, 2019

I have checked this again in two different oXygen installations, making sure that the editor variable was set (it was reset to "#AW" by the last update, so we changed it to the correct values) and that I pick the right command, and it still doesn't work.

The dialogue always shows only 1 window, the one asking for the gap's reason, but not the other asking for certainty. And the gap element is still lacking @cert.

So, I think we need to find out why it is working in one installation but not in others.

(Btw, has the plugin's update been committed to the master/develop branch already?)

@awagner-mainz awagner-mainz added the oXygen framework does not apply to anything facing externally, but to our oXygen framework label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working oXygen framework does not apply to anything facing externally, but to our oXygen framework
Projects
None yet
Development

No branches or pull requests

2 participants