Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROPC: FIx/mitigate ASP.NET Framework #33758

Open
Rick-Anderson opened this issue Sep 30, 2024 · 6 comments
Open

ROPC: FIx/mitigate ASP.NET Framework #33758

Rick-Anderson opened this issue Sep 30, 2024 · 6 comments
Assignees
Labels
sfi-ropc SFI-ROPC remediation

Comments

@Rick-Anderson
Copy link
Contributor

See list in #33703

@wadepickett
Copy link
Contributor

wadepickett commented Oct 1, 2024

@tdykstra, you ok with taking this one entirely, while I work on all the SFI images? I am taking on a couple hundred images to fix this sprint starting in order of worst severity and overall there are well over a 1000 to do. If so, I will take my name of this one.

@tdykstra
Copy link
Contributor

tdykstra commented Oct 1, 2024

@Rick-Anderson Should the title be "... Core and Framework"?

@wadepickett
Copy link
Contributor

@Rick-Anderson Should the title be "... Core and Framework"?

The list in the issue noted in the description is only for the AspNetDocs repo. Maybe to clarify we should just say this issue is for all ROPC issues int the AspNetDocs repo to be clear.

@tdykstra see my question above on me working on all the images (over 1000) while you handle ROPC. Thoughts?

@Rick-Anderson Rick-Anderson changed the title ROPC: FIx/mitigate ASP.NET Core Framework ROPC: FIx/mitigate ASP.NET Framework Oct 1, 2024
@Rick-Anderson
Copy link
Contributor Author

@Rick-Anderson Should the title be "... Core and Framework"?

Fixed

@tdykstra
Copy link
Contributor

tdykstra commented Oct 1, 2024

@wadepickett How about we start with that intent and re-evaluate how much time each of us has left to do after a sprint or two? If the list in #33703 is only ASP.NET Framework, where is the equivalent list for ASP.NET Core?

@wadepickett
Copy link
Contributor

wadepickett commented Oct 1, 2024

@wadepickett How about we start with that intent and re-evaluate how much time each of us has left to do after a sprint or two? If the list in #33703 is only ASP.NET Framework, where is the equivalent list for ASP.NET Core?

Great idea, let's go that route. I will focus on images, you on ROPC this sprint and we discuss how that is going as we start each new sprint to figure out if we need to move the work around between us.

We can group these by sprint for there severity or however we want to prioritize them.

I created new issues for fixing SFI flagged images. One per sprint (what I could fit into a sprint) per repo. So one for AspNetDocs and one for AspNetCore.Docs and one for EF, etc. Starting with the most severe first.

You could do the same with ROPC. Indicate a group you will hit in a repo based on priority that fits into this sprint and another for the next. One issue for each repo per sprint.

For repo AspNetCore.Docs there were 66 ROPC remaining items (maybe that is less now). The "list" at the moment is simply what is listed into the dashboard connected spreadsheet.

And the plan was to apply where we can the standard include regarding secure auth flow, see example pr #33408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sfi-ropc SFI-ROPC remediation
Projects
Development

No branches or pull requests

3 participants