Implement search functionality #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow get and search to find matches in notes Signed-off-by: Christian McHugh <[email protected]>
Signed-off-by: Christian McHugh <[email protected]>
Signed-off-by: Christian McHugh <[email protected]>
Signed-off-by: Christian McHugh <[email protected]>
Signed-off-by: Christian McHugh <[email protected]>
|
@doy may I ask whether you intend to merge this? This change looks like a no-brainer to me. It doesn't change existing functionality, but adds to it. I just need to know whether I have to retain my own fork. It seems that this project might be dead. e.g. what happens if someone opens a PR that adds support for attachments? Btw, this project is awesome. I never liked the bw cli client. However, since it can use attachments it is the only way, if you want to use bw for ssh-agent keys. I still hope someone adds attachment support to this project. ;-) |
|
thanks for the patch! i implemented this in a different way here 0d393e4, but let me know if this doesn't work the way you expect, or if you would like additional features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to close #114
Where
getwould display and error on multiple matches, search returns them all. With no additional arguments it lists the entry names. Using--rawworks as expected to expected to display this as a json list. While--fulldisplays the whole entry.Adds new search command
Modifies current get behavior to also search note content for matches
Never written rust before, so feedback is super welcome.