Adding r2_mlm() and possible update to r2() to work with it
#764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'master' of github.com:jluchman/performance # Conflicts: # inst/WORDLIST
|
what I consider is the opposite: running |
…edits; minor documentation edit
|
Update just pushed that incorporates the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
==========================================
- Coverage 58.52% 58.47% -0.05%
==========================================
Files 88 89 +1
Lines 6597 6623 +26
==========================================
+ Hits 3861 3873 +12
- Misses 2736 2750 +14 ☔ View full report in Codecov by Sentry. |
strengejacke
approved these changes
Aug 28, 2024
|
Thanks a lot, looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #758
This pull request includes a new function$R^2$ values for multivariate linear regression objects/objects of class
r2_mlm()that generates twoc("mlm", "lm")and is associated with issue #758.This pull request also adds an$R^2$ metric separated by response. I see value in this addition to the
multivariatelogical argument to ther2()function for its "mlm" S3 method that can invoke the computation of ther2_mlmbut is by default 'off'/FALSEand returns the currentr2()function but do understand if it is not in the spirit of the function and it is not deemed a value add.