Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resilience when executing on providers #69

Open
eneufeld opened this issue Mar 28, 2023 · 0 comments
Open

Improve resilience when executing on providers #69

eneufeld opened this issue Mar 28, 2023 · 0 comments
Labels
bug Something isn't working modelserver

Comments

@eneufeld
Copy link
Contributor

Currently we have code like this in the different provider-registries:

if (provider) {
    this.logger.debug('Invoking trigger provider(s)');
    result = await provider.getTriggers(modelURI, patch);

    return result;
}

This works fine as long the provider does not end with an error. As we can't rely on this assumption we should wrap the await in a try/catch and handle also the erroneous case.

@eneufeld eneufeld added bug Something isn't working modelserver labels Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working modelserver
Projects
None yet
Development

No branches or pull requests

1 participant