Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve File delete performance #1461

Open
jukzi opened this issue Jul 3, 2024 · 1 comment
Open

Improve File delete performance #1461

jukzi opened this issue Jul 3, 2024 · 1 comment
Labels
enhancement New feature or request performance

Comments

@jukzi
Copy link
Contributor

jukzi commented Jul 3, 2024

Currently Project/Clean... takes much time to only delete the output. Hopefully that can be improved - somehow

image
@jukzi jukzi added enhancement New feature or request performance labels Jul 3, 2024
@HannesWell
Copy link
Member

I wonder why RemoveDirectory is called if the element to be deleted is actually a file?

In general if the JDK implementation is too generic and therefore too slow we could consider adding a native (JNA, later FFM based) implementation by adding a delete() method to the NativeHandler? Maybe we can avoid some of the native calls done in nio.

jukzi pushed a commit to jukzi/eclipse.platform that referenced this issue Sep 20, 2024
@EcljpseB0T
[performance] LocalFile: delete Files of Directories in parallel ecli…
68d1151 
…pse-platform#1461

eclipse-platform#1461
@jukzi jukzi mentioned this issue Sep 20, 2024
Closed
jukzi pushed a commit to jukzi/eclipse.platform that referenced this issue Sep 20, 2024
@EcljpseB0T
[performance] LocalFile: delete Files of Directories in parallel ecli…
3d472b1 
…pse-platform#1461

eclipse-platform#1461
jukzi pushed a commit to jukzi/eclipse.platform that referenced this issue Sep 25, 2024
@EcljpseB0T
[performance] LocalFile: delete Files of Directories in parallel ecli…
236766e 
…pse-platform#1461

eclipse-platform#1461
jukzi pushed a commit to jukzi/eclipse.platform that referenced this issue Sep 25, 2024
@EcljpseB0T
[performance] LocalFile: delete Files of Directories in parallel ecli…
522e0aa 
…pse-platform#1461

eclipse-platform#1461
jukzi pushed a commit to jukzi/eclipse.platform that referenced this issue Sep 26, 2024
@EcljpseB0T
[performance] LocalFile: delete Files of Directories in parallel ecli…
24668fa 
…pse-platform#1461

There is no honest progress report as before. Just fixed the
InfiniteProgress to be thread safe and honestly using it.

eclipse-platform#1461
@jukzi jukzi mentioned this issue Sep 26, 2024
Merged
jukzi pushed a commit to jukzi/eclipse.platform that referenced this issue Sep 26, 2024
@EcljpseB0T
[performance] LocalFile: delete Files of Directories in parallel ecli…
3c04a2e 
…pse-platform#1461

There is no honest progress report as before. Just fixed the
InfiniteProgress to be thread safe and honestly using it.

eclipse-platform#1461
jukzi pushed a commit to jukzi/eclipse.platform that referenced this issue Sep 27, 2024
@EcljpseB0T
[performance] LocalFile: delete Files of Directories in parallel ecli…
797bbac 
…pse-platform#1461

There is no honest progress report as before. Just fixed the
InfiniteProgress to be thread safe and honestly using it.

eclipse-platform#1461
jukzi pushed a commit to jukzi/eclipse.platform that referenced this issue Sep 27, 2024
@EcljpseB0T
[performance] LocalFile: delete Files of Directories in parallel ecli…
a0ab67c 
…pse-platform#1461

There is no honest progress report as before. Just fixed the
InfiniteProgress to be thread safe and honestly using it.

eclipse-platform#1461
jukzi pushed a commit that referenced this issue Sep 27, 2024
@EcljpseB0T @jukzi
[performance] LocalFile: delete Files of Directories in parallel #1461
6d514be 
There is no honest progress report as before. Just fixed the
InfiniteProgress to be thread safe and honestly using it.

#1461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HannesWell @jukzi