Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checklist for reviewers #461

Open
vanessayuenn opened this issue Jan 10, 2018 · 1 comment
Open

checklist for reviewers #461

vanessayuenn opened this issue Jan 10, 2018 · 1 comment

Comments

@vanessayuenn
Copy link
Contributor

Currently, as a reviewer approving apps submission, I check the PR against the requirements listed in our contribution guide. The guide is super comprehensive, but a lot of the rules listed there are already automatically checked by tests as part of CI.

It will be very helpful to have a checklist of items that need human eyes & judgment. Better yet, have a bot that comments on each add app PR with said checklist so reviewers can check them off as they go!
@zeke
Copy link
Contributor

zeke commented Jan 10, 2018

Better yet, have a bot

Yes! I outlined a few bot ideas in #262 and #263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zeke @vanessayuenn