Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show departure list for multiple stations in a combined view #4

Open
evlli opened this issue Mar 2, 2024 · 7 comments
Open

Show departure list for multiple stations in a combined view #4

evlli opened this issue Mar 2, 2024 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@evlli
Copy link
Member

evlli commented Mar 2, 2024

from a user experience it would be nice to have multiple stations departures listed, each filtered by specific line's destinations, as we are in the middle of 4 stations and depending on where you want to go you want to choose a different station.

I would imagine a configuration like the following to use regex to show desired destinations.

it comes with the obvious downside of not showing redirected lines, but I'm sure we could come up with ideas for that aswell.

{
	"Rüppurrer Tor": {
		"3": "Daxlanden",
		"4": ".+",
		"5": ".+",
	},
	"Kronenplatz": {
		"1": "Durlach Bf",
		"2": "Wolfartsweier",
		"3": "Rintheim",
		"S2": "Reitschulschlag|Blankenloch|Spöck",
		"S4": "Bretten|Gölshausen|Flehingen|Eppingen|Heilbronn|Öhringen",
		"S5|S51": "Berghausen|Söllingen|Pforzheim Hbf",
		"S7|S8": "Tullastraße",
	},
	"Marktplatz": {
	        "1": "Heide",
	        "S5|S51": "Rheinbergstraße|Wörth (Rhein)|Wörth Badepark|Germersheim",
	        "S1|S11": "Neureut Kirchfeld|Hochstetten",
	},
	"Ettlinger Tor\/Stattstheater": {
	        ".+": "Hauptbahnhof",
	        "2": "Knielingen Nord"
	        "S1|S11": "Ettlingen Albgaubad|Ittersbach Rathaus|Bad Herrenalb"
	        "S4": "Albtalbahnhof",
	        "S7": "Rastatt|Baden-Baden|Bühl",
	        "S8": "Rastatt|Forbach|Freudenstadt|Bondorf",
	        "S52": "Wörth (Rhein)|Germersheim",
	},
}
@pascalwittler
Copy link
Member

Multi station support is already implemented. The currently shown tram stops are:

  • Kronenplatz
  • Marktplatz
  • Rüppurrer Tor

Each 15 seconds, the visible departure list cycles through the different stops listed above.

@pascalwittler
Copy link
Member

pascalwittler commented Mar 2, 2024

Is the feature you request a combined view and/or adding "Ettlinger Tor" as the fourth station?

@evlli
Copy link
Member Author

evlli commented Mar 2, 2024

I would like a combined view but I can understand if that's too complex

@pascalwittler
Copy link
Member

A combined view would not be too hard to implement. You can check if a tram/train has already passed another station from the list and show only its departure at the stop with the latest departure time.

The main disadvantage of a combined view that I personally see is the user experience:

A list with 11 lines (1, 2, 3, 4, 5, S1/S11, S2, S4, S5, S7, S8) with two possible directions each, departing from 4 stops means that you need at least 22 rows and an extra column (or at least more text) to indicate the stop to which a person must go for each departure.

A compromise to decrease the amount of visible (hard to read) text could be to only show the next ~10 departures, but then people would have to wait for their tram/train to appear in the list just like without a combined display.

@pascalwittler
Copy link
Member

The reason why the stop "Ettlinger Tor" is not displayed is that there is no possibility for lines to depart from this stop without also being available at any of the other three stops, neither during regular service nor in case of rerouting or route closures in any direction.

@pascalwittler pascalwittler added the enhancement New feature or request label Mar 2, 2024
@evlli
Copy link
Member Author

evlli commented Mar 2, 2024

my idea here was to have one "virtual station" with prioritized deduplication. I think we can just subtract the time-to-platform from the departure time and choose the highest value.
the servingLine.stateless id (something like kvv:21012:E:H:j24) in combination with AVMSTripID from the attrs dict should give us a unique identifier for each journey, regardless of what station it is at.

you think this approach might be worth implementing? it should also work flawlessly with rerouting of trips

@pascalwittler
Copy link
Member

I will keep this feature request in mind and probably implement a combined view for further evaluation later.

@pascalwittler pascalwittler changed the title feature(tram-departures): multi station support Show departure list for multiple stations in a combined view Mar 3, 2024
@pascalwittler pascalwittler added this to the Evaluated milestone Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants